This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Icon): handle brand icons #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
feat/brand-icons
branch
from
71f94b2
to
943f3e3
Compare
levithomason
changed the title
levithomason
force-pushed
the
feat/brand-icons
branch
from
943f3e3
to
f3dcdd4
Compare
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
+ Coverage 89.54% 89.54% +<.01%
==========================================
Files 62 62
Lines 1176 1177 +1
Branches 175 152 -23
==========================================
+ Hits 1053 1054 +1
Misses 121 121
Partials 2 2
Continue to review full report at Codecov.
|
levithomason
force-pushed
the
feat/brand-icons
branch
from
f3dcdd4
to
a8f7731
Compare
levithomason
force-pushed
the
feat/brand-icons
branch
from
a8f7731
to
8f44cbc
Compare
kuzhelov
reviewed
Oct 5, 2018
| @@ -20,10 +20,7 @@ const sizes = new Map([ | |||
| ]) | |||
|
|
|||
| const getDefaultFontIcon = (iconName: string) => { | |||
There was a problem hiding this comment.
it is better to explicitly specify the return type - otherwise we will lose this knowledge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply modifies the icon definitions to specify the correct family for each font awesome icon.