This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: remove 'skipLibCheck' flag requirement from client's projects #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
=======================================
Coverage 89.33% 89.33%
=======================================
Files 64 64
Lines 1257 1257
Branches 186 163 -23
=======================================
Hits 1123 1123
Misses 131 131
Partials 3 3Continue to review full report at Codecov.
|
kuzhelov
added
🚀 ready for review
🧰 fix
hughreeling
approved these changes
Oct 17, 2018
build/gulp/tasks/test-projects.tsx
Outdated
|
|
||
| const runInTestApp = runIn(testAppPath()) | ||
| log(`Test React project is successfully created: ${testAppPath()}`) | ||
|
|
||
| //////// ADD STARDUST AS A DEPENDENCY /////// | ||
| log('STEP 2. Add Stardust dependency to test project..') | ||
|
|
||
| await runInTestApp(`yarn add ${paths.base(stardustPackageFilename)}`) | ||
| await runInTestApp(`npm install add ${paths.base(stardustPackageFilename)}`) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
This PR serves the main goal to eliminate requirement of using
skipLibCheckTS compiler flag in client's TS projects (fixes #276). Detailed overview is provided below.Address
skipLibCheckproblemProblem
skipLibCheckwas a mandatory flag for client's TS projects to consume Stardust.Solution
With
typescriptpackage has been upgraded to 3.1.* this issue is fixed (fix for the related one microsoft/TypeScript#27136 has resolved problem for us). To prevent potential breaking changes with new version of TS compiler being released, more strict expression has been used inpackage.jsonto control its version. Not necessary anymore gulp plugin has been removed.Wrong local debug results for
yarn test:projects:cra-tsProblem
The problem represents itself in the following form - while trying to debug
yarn test:projects:cra-tscommand developer might observer the fact that after this command being run once and local changes being introduced to Stardust files, the unchanged files are used in @stardust package installed for test project. Cause of the problem is thatyarn addcommand results in added package being implicitly cached (https://yarnpkg.com/lang/en/docs/cli/cache/). This behavior results in cached package files used with each repetition of this command (note that this primarily attributes to local debugging cases, as for CI clean container is deployed each time).Solution
This problem is fixed by replacing
yarn addcommand onnpm installone for test scenario.