This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
test: component description conformance test #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
test/component-descriptions
branch
2 times, most recently
from
abb8135
to
25b312d
Compare
levithomason
changed the title
levithomason
added
good first issue
levithomason
commented
Oct 24, 2018
| "test:visual": "gulp screener", | ||
| "test:projects:cra-ts": "gulp test:projects:cra-ts", | ||
| "test:watch": "yarn test --watchAll", | ||
| "test:watch": "gulp test:watch", |
There was a problem hiding this comment.
This change was required to run jest's watch and gulp's doc watch commands in parallel. The watchers never exit so they cannot be started in series.
levithomason
force-pushed
the
test/component-descriptions
branch
from
547947f
to
1d5b3e8
Compare
alinais
approved these changes
Nov 1, 2018
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 41 41
Lines 1324 1324
Branches 168 168
=======================================
Hits 1215 1215
Misses 105 105
Partials 4 4
Continue to review full report at Codecov.
|
mnajdova
reviewed
Nov 2, 2018
| @@ -45,6 +45,7 @@ export interface RadioGroupItemState { | |||
| } | |||
|
|
|||
| /** | |||
| * A single radio with a radio group. | |||
There was a problem hiding this comment.
'A single radio within a radio group.' might be better description
mnajdova
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a failing conformance test for missing component descriptions. It also attempts to add some heuristics around detecting an unhelpful component description.
Workflow changes
Watch and rebuild component info JSON files during tests. This enables changes to doc info, like descriptions, to be picked up and tested between tests. Specifically, conformance tests can now be run in watch mode and successfully pick up on changes to documentation concerns.
Tests added