Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Attachment): do not render progress value #402

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Oct 25, 2018

Fixes #385

This PR prevents the Attachment's progress value from the rendered to the DOM. It is only used for styling purposes.

Before

image

After

image

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #402 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          41       41           
  Lines        1341     1341           
  Branches      197      197           
=======================================
  Hits         1230     1230           
  Misses        107      107           
  Partials        4        4
Impacted Files Coverage Δ
src/components/Attachment/Attachment.tsx 97.14% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 435182b...1f7eaf5. Read the comment docs.

@miroslavstastny miroslavstastny merged commit e4ba17d into master Oct 25, 2018
@miroslavstastny miroslavstastny deleted the fix/attachment-progress branch October 25, 2018 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants