This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Segment): add background color #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
fix/segment-background
branch
from
78a2d69
to
d7ab4b6
Compare
|
|
||
| export interface SegmentVariables { | ||
| padding: string | ||
| color: string |
There was a problem hiding this comment.
color and fontSize are not used anywhere in segmentStyles
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 41 41
Lines 1341 1341
Branches 197 172 -25
=======================================
Hits 1230 1230
Misses 107 107
Partials 4 4Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #407, the Segment does not have a background color currently.
This PR adds a background color that matches the body background. A few other style values were also hoisted to the variables position.