Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Header): Adding dark and contrast styles for Header #427

Merged
merged 7 commits into from
Nov 12, 2018

Conversation

bcalvery
Copy link
Contributor

@bcalvery bcalvery commented Nov 2, 2018

Adding Dark and Contrast theme variables for Header

image
image
image

@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files          41       41           
  Lines        1387     1387           
  Branches      202      177   -25     
=======================================
  Hits         1234     1234           
  Misses        149      149           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f71e12...90dc28c. Read the comment docs.

@bcalvery
Copy link
Contributor Author

bcalvery commented Nov 2, 2018

@mnajdova, you worked on the Theme Switcher, could you possibly shed some light on this?
image

@alinais alinais added the redlines Update of the redlines for the mentioned component label Nov 5, 2018
@mnajdova
Copy link
Contributor

mnajdova commented Nov 5, 2018

@bcalvery when the theme is changed, it is changed for all page. That means, every stardust component we are using on the page, is going to change it's appearance. The headers here, seems to be implemented using the Stardust's Header components, so we will need on changing the theme, to maybe change the docs's background color (the same is already done for the examples (you can see that on dark theme, the background is dark). Another approach would be to wrap these two Header components with Provider and always provide the team's default theme, so it would be the last theme applied. Ping me if you need some help with this.

@alinais alinais added this to bcalvery in Core Team Nov 6, 2018
@codepretty codepretty self-requested a review November 6, 2018 19:07
@codepretty
Copy link
Collaborator

Looks good. Is there an issue creating to fix the theme switcher?


export default (siteVars: any): HeaderVariables => {
return {
color: 'black',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be siteVars.black?

@mnajdova
Copy link
Contributor

mnajdova commented Nov 8, 2018

@bcalvery I commited the changes required for the docs' Header components to always be black. Ping me if there is anything else.

image

@alinais alinais merged commit 0265788 into master Nov 12, 2018
@alinais alinais deleted the fix/header-darkthemes branch November 12, 2018 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀 ready for review redlines Update of the redlines for the mentioned component
Projects
No open projects
Core Team
  
bcalvery
Development

Successfully merging this pull request may close these issues.

None yet

5 participants