Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

breaking(Menu): replace type with primary/secondary #429

Merged
merged 6 commits into from
Nov 5, 2018

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Nov 5, 2018

BREAKING CHANGES

Refs #421.

1. Replacement the type prop with primary and secondary

Before

<Menu type='primary' />

After

<Menu primary />

2. Rename theme variables that belongs for primary styling

Before

  typePrimaryActiveColor: string
  typePrimaryActiveBackgroundColor: string
  typePrimaryActiveBorderColor: string

  typePrimaryBorderColor: string
  typePrimaryHoverBorderColor: string
  typePrimaryUnderlinedBorderColor: string

After

  primaryActiveColor: string
  primaryActiveBackgroundColor: string
  primaryActiveBorderColor: string

  primaryBorderColor: string
  primaryHoverBorderColor: string
  primaryUnderlinedBorderColor: string

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #429 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
+ Coverage   91.79%   91.84%   +0.05%     
==========================================
  Files          41       41              
  Lines        1328     1337       +9     
  Branches      168      168              
==========================================
+ Hits         1219     1228       +9     
  Misses        105      105              
  Partials        4        4
Impacted Files Coverage Δ
src/components/Menu/MenuItem.tsx 80% <ø> (ø) ⬆️
src/components/Menu/Menu.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81d3715...cc821ad. Read the comment docs.

/** The menu can have primary or secondary type */
type: PropTypes.oneOf(['primary', 'secondary']),
/** The menu can have secondary type. */
secondary: PropTypes.bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make primary and secondary mutually exclusive.

@layershifter layershifter changed the title [WIP] breaking(Menu): replace type with primary/secondary breaking(Menu): replace type with primary/secondary Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants