This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
breaking(Menu): replace type
with primary
/secondary
#429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theme variables
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
November 5, 2018 10:46
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 91.79% 91.84% +0.05%
==========================================
Files 41 41
Lines 1328 1337 +9
Branches 168 168
==========================================
+ Hits 1219 1228 +9
Misses 105 105
Partials 4 4
Continue to review full report at Codecov.
|
src/components/Menu/Menu.tsx
Outdated
/** The menu can have primary or secondary type */ | ||
type: PropTypes.oneOf(['primary', 'secondary']), | ||
/** The menu can have secondary type. */ | ||
secondary: PropTypes.bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make primary
and secondary
mutually exclusive.
layershifter
changed the title
[WIP] breaking(Menu): replace
breaking(Menu): replace Nov 5, 2018
type
with primary
/secondary
type
with primary
/secondary
layershifter
force-pushed
the
breaking/menu-type
branch
from
November 5, 2018 11:57
6324c0b
to
256d9fd
Compare
alinais
approved these changes
Nov 5, 2018
miroslavstastny
approved these changes
Nov 5, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Refs #421.
1. Replacement the
type
prop withprimary
andsecondary
Before
After
2. Rename theme variables that belongs for primary styling
Before
After