Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Chat): Set default chatBehavior which uses Enter/Esc keys #443

Merged
merged 6 commits into from
Nov 8, 2018

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Nov 7, 2018

Currently, we have implemented 2 chat behaviors:

  • chatBehavior- uses ArrowRight and ArrowLeft to go in and out of the message
  • chatEnterEscBehavior - uses Enter and Esc to go in and out of the message

After a couple of discussions, we agreed that default behavior should be the one that uses Enter and Esc.
Chat behavior which uses ArrowRight and ArrowLeft currently not needed, so it was removed from the repo.

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #443 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   91.82%   91.79%   -0.03%     
==========================================
  Files          41       41              
  Lines        1333     1329       -4     
  Branches      168      168              
==========================================
- Hits         1224     1220       -4     
  Misses        105      105              
  Partials        4        4
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed616f0...50daec4. Read the comment docs.

@sophieH29 sophieH29 changed the title Set default chatBehavior which using Enter/Esc keys Set default chatBehavior which uses Enter/Esc keys Nov 7, 2018
@sophieH29 sophieH29 added the 🧰 fix Introduces fix for broken behavior. label Nov 7, 2018
@miroslavstastny miroslavstastny changed the title Set default chatBehavior which uses Enter/Esc keys feat(Chat): Set default chatBehavior which uses Enter/Esc keys Nov 7, 2018
Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update changelog

@sophieH29 sophieH29 added ready for merge and removed 🧰 fix Introduces fix for broken behavior. labels Nov 8, 2018
@sophieH29 sophieH29 merged commit 34bf5f1 into master Nov 8, 2018
@sophieH29 sophieH29 deleted the fix/default-chat-behavior-enter-esc branch November 8, 2018 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants