This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Types): remove Sizes and Weights enums, use typed string in Text instead #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
miroslavstastny
approved these changes
Nov 7, 2018
Codecov Report
@@ Coverage Diff @@
## master #446 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 41 41
Lines 1337 1337
Branches 168 193 +25
=======================================
Hits 1228 1228
Misses 105 105
Partials 4 4
Continue to review full report at Codecov.
|
layershifter
approved these changes
Nov 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textcomponent hadsizeproperty typed asSizes. But sinceSizeswas not exported, it was not possible to use it. The agreement is to replace it with just strings and remove bothSizesandWeightsenums.In theory this changes the API but I'm not going to mark this as a breaking change since the previous API version was not usable.