This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): add 'backgroundColor' variable #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'backgroundColor' variable for Icon
This variable will introduce possibility to specify Icon's background color. In contrast with just
inverted
property being introduced, withbackgroundColor
variable we will provide all the necessary means to customize look of the icon to the client - without necessity to use heuristics for detecting which foreground color would be more appropriate for the given background one.No corresponding property is introduced intentionally - to prevent abuse in using props as styling fine-tuning mechanism. For the sake of consistency corresponding
color
property has been eliminated for now as well - until we will come up to the common set of predefined color constants that will be supported by each component.TODO
API Proposal
backgroundColor: string (variable)