This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(typings): include for each module target #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov and
mnajdova
as code owners
levithomason
force-pushed
the
fix/dist-typings
branch
from
2db442c
to
116ac40
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typings cannot be found by consumers using the
esmodule target. The issue is that there is no index.d.ts in the root of the module target that points to the correct/typingsdirectory.Instead, we'll simply ship typings for each module target.
I have noted the changes under
v0.2.5since we'll be shipping this immediately after merge.