This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(menu): iconOnly does not overlap big icons #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
@miroslavstastny can you take a look? |
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
=========================================
Coverage ? 88.17%
=========================================
Files ? 42
Lines ? 1455
Branches ? 187
=========================================
Hits ? 1283
Misses ? 167
Partials ? 5Continue to review full report at Codecov.
|
miroslavstastny
added
needs author changes
|
@miroslavstastny |
bmdalex
added
💥 blocked
postponed
|
Blocked by change of priorities; will resume working in upcoming days |
bmdalex
force-pushed
the
fix/menu-icon-only
branch
3 times, most recently
from
e81ac13
to
54400fe
Compare
|
@miroslavstastny pls take another look, issue with key nav focus outline is fixed:
|
bmdalex
added
🚀 ready for review
and removed
💥 blocked
needs author changes
bmdalex
force-pushed
the
fix/menu-icon-only
branch
from
54400fe
to
200f737
Compare
bmdalex
force-pushed
the
fix/menu-icon-only
branch
from
200f737
to
346fc29
Compare
miroslavstastny
approved these changes
Nov 30, 2018
kuzhelov
reviewed
Dec 4, 2018
kuzhelov
approved these changes
Dec 4, 2018
bmdalex
force-pushed
the
fix/menu-icon-only
branch
from
8f5017d
to
a90977a
Compare
- added changelog
bmdalex
force-pushed
the
fix/menu-icon-only
branch
from
a90977a
to
6228771
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(menu): iconOnly does not overlap big icons
Fixes #409
Before fix:
After fix: