This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
Fix(Popup): Trigger's props are not passed in onClick handler #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses fix for a small issued encountered in Popup
Let's say we have a Popup, with Button component as a trigger
For Button's
onClick
you expect to receive 2 arguments,event
andprops
, but in fact, receive onlyevent
object as popup's handler cut off this from click event pipeline.Even bigger issue with that can be found, when use
Popup
asMenuItem
When click on
MenuItem
, event firstly propagates to Popup which cut off essential props, thenMenu
handles that event and can't find props as arguments.