This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Provider): staticStyles should be executed with the merged siteVariables #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 4, 2018 13:43
…t once in one Provider instance.
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
miroslavstastny
as code owners
layershifter
reviewed
Dec 5, 2018
| super(props) | ||
| this.staticStylesRendered = false | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| staticStylesRendered: boolean = false |
You can set a value without constructor, or I am missing something?
There was a problem hiding this comment.
Yep, I will remove the constructor. I was trying different things, it is just leftover.
added 2 commits
December 5, 2018 15:46
…rovider -added test for ensuring that staticStyles are invoked with the merged siteVariables
levithomason
approved these changes
Dec 5, 2018
kuzhelov
approved these changes
Dec 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #526
Note
Important thing to note is that, per one Provider we will execute the staticStyles only once, when they are the first time applied.