fix(Menu): correctly handle isFromKeyboard

[layershifter]

Fixes #434.

---

I investigated the issue a bit more and it comes from our side. We have own event listener for onFocus and it has the higher priority than a handler from what-input. This means that our handlers will always take an unactual value from whatInput.ask().

I also tried to play around with a wrapper component (via Custom Callbacks) that will handle this properly, but didn't reach a good and simple result. isFromKeyboard is respected only when component is focused, this means that we need separately handle focus and blur events and also events from what-input.

---

As were suggested, I made a cleanup there:

• copied library and removed unused functions
• add useCapture in addEventListener
• drop what-input dependency
• removed isFromKeyboard.ts as util
• typescriptUtils.ts also removed because they were used only by isFromKeyboard.ts

---

TODO

• update CHANGELOG

[sophieH29]

If we are copying the whole library, I think might be worth to optimize it a bit, and get rid of things that we are not using. For example, I am not sure about data-whatintent, as we are reading value from data-whatinput. Also additional props like ignoreKeys and so on are not used and can be removed.

Basically, what we need it's just to get info if the last input was 'keyboard'. So I suggest to leave everything that is related to it and remove anything else.
touchstart and touchend are triggered only for mobile, so we might not need it also as input won't be changed to 'keyboard' on mobile

[layershifter]

Agree, but this will mean that we want to adopt it. I'm not sure that actually need to do this.

[layershifter]

We also don't need fireFunctions and many other stuff, but as I see: we need to fix our bug and just wait for this function in the module.

And may be, a more better solution that matches React's ideas. Because even with setInput() it will still be a monkey patch.

[sophieH29]

we can start with removing unused things (because it's easy and fast :)) as waiting for this thing to be fixed in a module takes an unknown time.
Reinventing something new, more in React way, might be considered for some future RFC, but at least we need to get back from authors that they won't fix it.

[layershifter]

Please understand my position there, we have two options.

Option 1. We want to get an enchantment in the package and we will temporary copy its code as is. We know that this code is stable and working, we should not touch it at all.

Option 2. We fork the package and adopt it for our needs. In this case I of course will remove all unused options.

[levithomason]

Option 3: Let's try deleting as much of this as possible. The isFromKeyboard abstraction currently has lots of code that is unnecessary. I'm also not sure if we need this utility or if it can be done in a more simple way.

[layershifter]

I reworked this as you suggested guys.

• drop what-input
• removed isFromKeyboard.ts with util
• typescriptUtils.ts also removed
• removed unused functions and intent in whatInput.ts

For now, we have only a isFromKeyboard() function. Issue with events priority was resolved by useCapture.

---

However, I would be glad if matching changes were done in third party dependency and will be able to remove whatInput.ts from our code.

[miroslavstastny]

Does it make sense for isFromKeyboard to be autocontrolled?

[layershifter]

This looks really strange to me, agree. Will remove this.