This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): ensure popup is closing on outside click #598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue is described here: #557
TODO
Root cause
The cause of the problem is the fact that
Menu
component "intercepts" click event, so thatPopup
is unaware of whether this event has happened or not.Fix
useCapture
event interception logic is now used forPopup
event subscriptions - this will guarantee that event won't pass unnoticed.