This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(icon): update size values in Icon #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
changed the title
codepretty
changed the title
kuzhelov
approved these changes
Dec 20, 2018
codepretty
changed the title
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
We want the size of components across Stardust to be consistent. The sizing scheme we decided to go with for now is: smallest, smaller, small, medium, large, larger, largest. This PR is to update the sizes for an Icon to match this scheme. This reduces the number of available values for Icon sizes from 9 to 7 sizes.
This doesn't change the Icon api, but it modifies the allowed values for the
sizeprop on Icon. Whereas before, you could use values liketinythis will no longer produce a smaller than default icon.<Icon name="home" size="tiny" />The above example will still render, but as the
medium(default) size. To achieve the same look, you will need to update thesizeprop value to be one of the allowed values.<Icon name="home" size="smaller" />