This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): defaultOpen prop #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
sophieH29
reviewed
Dec 20, 2018
| @@ -183,8 +183,6 @@ export default class Popup extends AutoControlledComponent<ReactProps<PopupProps | |||
| } | |||
| } | |||
|
|
|||
| public state = { target: undefined, open: false } | |||
|
|
|||
There was a problem hiding this comment.
Just to raise attention, there is an issue currently in Autocontrolled component. It doesn't allow to have both autocontrolled and non-controlled state.
Created this 1 week ago - #610
Because it might be needed to have an initial state explicitly set for target
There was a problem hiding this comment.
the target is also an auto-controlled prop in this case, so it is safe to be removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #657 -
defaultOpenprop on thePopupis not working.