This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Accordion|Dropdown): fix default props in auto controlled mode #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
…ithub.com/stardust-ui/react into fix/acc-accordion-dropdown
layershifter
commented
Jan 3, 2019
| @@ -118,8 +118,6 @@ class Accordion extends AutoControlledComponent<ReactProps<AccordionProps>, any> | |||
| static Title = AccordionTitle | |||
| static Content = AccordionContent | |||
|
|
|||
| state: any = { activeIndex: [0] } | |||
|
|
|||
| getInitialAutoControlledState({ exclusive }) { | |||
| return { activeIndex: exclusive ? -1 : [-1] } | |||
There was a problem hiding this comment.
This line didn't work previously, that's why we have visual regressions there.
There was a problem hiding this comment.
To me it seems, according to the changes in screener that that line was indeed working:
as the previous accepted screen has the first element inside active. Not quite sure how did you conclude that it was not working before.. Maybe I am missing something?
There was a problem hiding this comment.
I understand that this is part of the autocontroll props and should not be initialized, but can't understand why do you say it was not working previously
layershifter
changed the title
…ithub.com/stardust-ui/react into fix/acc-accordion-dropdown # Conflicts: # CHANGELOG.md
layershifter
force-pushed
the
fix/acc-accordion-dropdown
branch
from
868753a
to
ce65f1c
Compare
mnajdova
approved these changes
Jan 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610.