This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(slot): rename Slot to Box and export #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
reviewed
Jan 14, 2019
kuzhelov
reviewed
Jan 14, 2019
kuzhelov
approved these changes
Jan 14, 2019
There was a problem hiding this comment.
approving the PR as this rename has been agreed upon - but my personal feeling is that this move introduces even more misleading moments (have pointed a few in the PR) than we have before.
Also, this generic Component name doesn't provide any context on its semantics and where it should be used, in contrast to the former Slot name.
It would be great if we would wait for others' opinions before merging.
kuzhelov
reviewed
Jan 14, 2019
kuzhelov
added
the
question
bmdalex
force-pushed
the
feat/slot-component-renaming
branch
from
582d3dc
to
75a8c90
Compare
bmdalex
changed the title
bmdalex
force-pushed
the
feat/slot-component-renaming
branch
from
75a8c90
to
11b1e7d
Compare
bmdalex
added
postponed
|
Postponing until solving a dependency |
bmdalex
force-pushed
the
feat/slot-component-renaming
branch
from
11b1e7d
to
b1a857f
Compare
bmdalex
removed
the
postponed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(slot): rename Slot to Box and export
Description
This PR:
Slotcomponent toBoxBox(formerSlot)