This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(core): replace lodash/fp with lodash #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
miroslavstastny
commented
Jan 16, 2019
package.json
Outdated
| @@ -164,6 +164,7 @@ | |||
| "tslint": "^5.11.0", | |||
| "tslint-config-airbnb": "^5.11.1", | |||
| "typescript": "~3.2.2", | |||
| "weak": "^1.0.1", | |||
There was a problem hiding this comment.
required by jest --detectLeaks
miroslavstastny
changed the title
miroslavstastny
added
🚀 ready for review
🧰 fix
layershifter
approved these changes
Jan 18, 2019
| @@ -39,27 +37,27 @@ export const suggest = (suggestions: string[]) => { | |||
| const findBestSuggestions = _.memoize((str: string) => { | |||
| const propValueWords = str.split(' ') | |||
|
|
|||
| return _.flow( | |||
| _.map((suggestion: string) => { | |||
| return _.chain(suggestions) | |||
There was a problem hiding this comment.
Heads up that _.chain causes all (or almost all) of lodash to be imported because all the chainable functions must be available on the returned object, and lodash can't statically detect which will be used (i.e. tree shaking will not work). Recommend refactoring to reduce the weight of our library.
https://medium.com/making-internets/why-using-chain-is-a-mistake-9bc1f80d51ba
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a workaround which fixes #703.
Instead of using
lodash/fp, stardust now useslodash.This PR also runs
jesttests with--detectLeaksas part of CI.