This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): Highlights selected option in single selection #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
force-pushed
the
fix/highlight-on-selected
branch
from
e07fe1d
to
461ea53
Compare
silviuaavram
changed the title
silviuaavram
changed the title
silviuaavram
changed the title
silviuaavram
force-pushed
the
fix/highlight-on-selected
branch
from
461ea53
to
183261d
Compare
There was a problem hiding this comment.
Downshift has highlightedIndex, too. Can we implement it as autocontrolled prop?
silviuaavram
force-pushed
the
fix/highlight-on-selected
branch
from
8d156d8
to
ee9100f
Compare
|
@layershifter let's create a new issue with making those props autocontrolled. It will be a bit more complicated, as our |
mnajdova
reviewed
Jan 29, 2019
bmdalex
approved these changes
Jan 29, 2019
jurokapsiar
approved these changes
Jan 29, 2019
mnajdova
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights selected option when opening dropdown.
Based on downshift-js/downshift#652 and since now it's released, this PR will be able to perform the necessary fix.