This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(ComponentSidebar): remove empty item in docs sidebar #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Jan 15, 2019
| } | ||
|
|
||
| componentWillReceiveProps(nextProps) { | ||
| this.fetchSections(nextProps) | ||
| componentDidUpdate(prevProps: ComponentSidebarProps) { |
There was a problem hiding this comment.
Switched from deprecated componentWillReceiveProps
layershifter
commented
Jan 15, 2019
| import(`docs/src/exampleMenus/${displayName}.examples.json`).then(sections => { | ||
| this.setState({ sections }) | ||
| this.setState({ sections: sections.default }) |
There was a problem hiding this comment.
import() returned all exported keys, but also returned default
{
section1: '',
section2: '',
default: {
section1: '',
section2: '',
}
}
alinais
approved these changes
Jan 15, 2019
miroslavstastny
approved these changes
Jan 17, 2019
layershifter
force-pushed
the
docs/useless-item
branch
from
15b4d2b
to
d11248e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616.