This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Dropdown): add loading prop
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
feat/dropdown-loading
branch
from
e00bad1
to
6d08667
Compare
layershifter
commented
Jan 17, 2019
|
|
||
| fontWeight: 'bold', | ||
| }), | ||
| } |
There was a problem hiding this comment.
We have a task for cleaning up styles in Dropdown, we should separate variables between components and them meaningful.
layershifter
changed the title
loading proploading prop
21 tasks
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
...es/components/Dropdown/Variations/DropdownExampleMultipleSearchImageAndContent.shorthand.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jan 21, 2019
docs/src/prototypes/AsyncDropdownSearch/AsyncDropdownSearch.tsx
Outdated
Show resolved
Hide resolved
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
kuzhelov
reviewed
Jan 21, 2019
layershifter
commented
Jan 22, 2019
….com/stardust-ui/react into feat/dropdown-loading # Conflicts: # CHANGELOG.md # docs/src/examples/components/Dropdown/index.tsx # src/components/Dropdown/Dropdown.tsx
…at/dropdown-loading # Conflicts: # CHANGELOG.md # docs/src/components/CodeSnippet.tsx
mnajdova
reviewed
Jan 22, 2019
mnajdova
reviewed
Jan 22, 2019
mnajdova
reviewed
Jan 22, 2019
…at/dropdown-loading # Conflicts: # CHANGELOG.md
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
reviewed
Jan 22, 2019
kuzhelov
reviewed
Jan 22, 2019
src/themes/teams/components/Dropdown/dropdownMessageLoadingStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 23, 2019
| }), | ||
| !loading && | ||
| items.length === 0 && | ||
| ListItem.create(noResultsMessage, { |
mnajdova
reviewed
Jan 23, 2019
mnajdova
approved these changes
Jan 23, 2019
….com/stardust-ui/react into feat/dropdown-loading
silviuaavram
approved these changes
Jan 24, 2019
….com/stardust-ui/react into feat/dropdown-loading # Conflicts: # CHANGELOG.md # src/components/Dropdown/Dropdown.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
1. Rename
toggleButtontotoggleIndicatorReason: this slot is not a button, it cannot be focused or be selected in native
select, too.Before
After
2.
toggleIndicatoris visible by defaultReason: it's a common UI behavior to show toggles by default.
Before
After
Customizing
loadingMessage