Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Popup): Do not stop propagation when pressing Esc on trigger element #750

Merged
merged 2 commits into from
Jan 21, 2019
Merged

fix(Popup): Do not stop propagation when pressing Esc on trigger element #750

merged 2 commits into from
Jan 21, 2019

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Jan 21, 2019 •
edited

Bug reported:

  • Chat Message with popover prototype (keyboard nav):

Fix:
There shouldn't be e.stopPropagation for close action in Popup component. e.stopPropagation was added initially for closeAndFocusTrigger actions based on reasons described in this PR #515, but it wasn't needed when pressing Esc just on trigger button, what was added here #622

@sophieH29 sophieH29 added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. labels Jan 21, 2019
@sophieH29 sophieH29 self-assigned this Jan 21, 2019
@sophieH29 sophieH29 merged commit 0fd14dc into master Jan 21, 2019
@sophieH29 sophieH29 deleted the fix/popup-do-not-stop-propagation-on-esc branch January 21, 2019 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kuzhelov kuzhelov kuzhelov approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@sophieH29 sophieH29

Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sophieH29 @kuzhelov