This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat: remove props from variables function #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
changed the title
kuzhelov
commented
Jan 24, 2019
| }), | ||
| }), | ||
| icon: ({ props: p, variables: v, theme }): ICSSInJSStyle => { | ||
| const { siteVariables: siteVars } = theme |
There was a problem hiding this comment.
will simplify this expression
| ...(p.isFromKeyboard && { | ||
| // this creates both inset and outset box shadow that some readers (NVDA) show when radio is not checked but it is focused | ||
| boxShadow: | ||
| `0 0 0 ${pxToRem(1)} ${siteVars.brand},` + `0 0 0 ${pxToRem(2)} ${siteVars.brand} inset`, |
There was a problem hiding this comment.
Can we move this to variables to omit siteVars usage?
alinais
approved these changes
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
We've agreed to move from providing
propsas an argument to variables function - leavingsiteVariablesbeing the only one provided. This move will make order of styles resolution (as well as list of dependencies used on each stage) much cleaner and reasonable: