This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
refactor(Portal): allow to use createRef() API in triggerRef #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
miroslavstastny
approved these changes
Jan 29, 2019
kuzhelov
reviewed
Jan 29, 2019
src/components/Portal/Portal.tsx
Outdated
| doesNodeContainClick(this.triggerNode, e) || // event happened in trigger (delegate to trigger handlers) | ||
| doesNodeContainClick(this.portalNode, e) // event happened in the portal | ||
| !this.portalRef.current || // no portal | ||
| doesNodeContainClick(this.triggerRef.current, e) || // event happened in trigger (delegate to trigger handlers) |
There was a problem hiding this comment.
this method doesNodeContainClick is working with DOM modes only. We should preserve original code of this method and just pass DOM nodes there explicitly - this will make contract of this method to be explicit
kuzhelov
reviewed
Jan 29, 2019
src/components/Portal/Portal.tsx
Outdated
| this.triggerNode = triggerNode | ||
|
|
||
| _.invoke(this.props, 'triggerRef', triggerNode) | ||
| handleRef(this.triggerRef, triggerNode) |
There was a problem hiding this comment.
once again this strikes my cognitive process :) I really think that setRef will be much more intuitive name for this method as, essentially, this is what it does
kuzhelov
reviewed
Jan 29, 2019
src/components/Portal/Portal.tsx
Outdated
| @@ -57,9 +58,9 @@ export interface PortalProps extends ChildrenComponentProps, ContentComponentPro | |||
| /** | |||
| * Called with a ref to the trigger node. | |||
| * | |||
| * @param {JSX.Element} node - Referred node. | |||
| * @param {HTMLElement} node - Referred node. | |||
There was a problem hiding this comment.
this could be removed now
kuzhelov
reviewed
Jan 29, 2019
src/components/Portal/Portal.tsx
Outdated
| @@ -103,7 +104,7 @@ class Portal extends AutoControlledComponent<ReactPropsStrict<PortalProps>, Port | |||
| onUnmount: PropTypes.func, | |||
| open: PropTypes.bool, | |||
| trigger: PropTypes.node, | |||
| triggerRef: PropTypes.func, | |||
| triggerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.object]), | |||
There was a problem hiding this comment.
probably, this is a good candidate for custom prop types - would expect this to appear in multiple places
kuzhelov
approved these changes
Jan 29, 2019
layershifter
force-pushed
the
refactor/portal
branch
from
c03fc36
to
b62909a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR allow to use
createRefAPI intriggerRef.