This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Dialog): add component #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
feat/dialog
branch
from
dea49fc
to
00b4024
Compare
layershifter
changed the title
jurokapsiar
reviewed
Jan 31, 2019
src/components/Dialog/Dialog.tsx
Outdated
| {...accessibility.keyHandlers.popup} | ||
| {...unhandledProps} | ||
| > | ||
| {Box.create(header, { |
There was a problem hiding this comment.
Can we use the Header component here? By default we should render H2: https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
Also, would it be possible to allow adding aria-labelledby (which needs an ID reference to the header)?
The logic should be:
- by default, generate aria-labelledby
- if aria-labelledby provided by the user, use that instead
- if aria-label provided, do not generate aria-labelledby
For aria-describedby I would leave it fully on the consumer to provide correct referecne as not all dialogs have clear description.
There was a problem hiding this comment.
Replaced with Header, fda25b7
There was a problem hiding this comment.
Created an issue for arias, #812
…ust-ui/react into feat/dialog # Conflicts: # CHANGELOG.md
miroslavstastny
approved these changes
Jan 31, 2019
…ust-ui/react into feat/dialog # Conflicts: # CHANGELOG.md
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements basic Dialog component.