This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore: add RTL examples for visual testing #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
added 2 commits
January 29, 2019 16:39
mnajdova
commented
Jan 29, 2019
| </SourceRender.Consumer> | ||
| </SourceRender> | ||
| <Provider theme={{ rtl: isRtlEnabled }}> | ||
| {/*<div dir={isRtlEnabled ? 'rtl' : undefined}>*/} |
There was a problem hiding this comment.
Not sure whether we should add this wrapper div that will have dir='rtl' if rtl is enabled. We have that logic in the ComponentExample component.
There was a problem hiding this comment.
We definitely need it.
Without
With
alinais
approved these changes
Jan 29, 2019
|
|
||
| const DividerExampleShorthand = () => <Divider content="مثال النص" /> | ||
|
|
||
| export default DividerExampleShorthand |
There was a problem hiding this comment.
Suggested change
| export default DividerExampleShorthand | |
| export default DividerExampleRtl |
May be name should be changed?
CHANGELOG.md
Outdated
| @@ -20,6 +20,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| ### Fixes | |||
| - Fix layout of `Accordion` panel's title @kuzhelov ([#780](https://github.com/stardust-ui/react/pull/780)) | |||
|
|
|||
| ### Features | |||
| - Add mechanism for adding rtl visual tests @mnajdova ([#792](https://github.com/stardust-ui/react/pull/792)) | |||
There was a problem hiding this comment.
I'm not sure that we should have an entry in CHANGELOG about it, there are no any benefits for user from this change
layershifter
approved these changes
Jan 30, 2019
-added rtl ecamples for the Button and Divider components -rtl examples are in rtl mode by default
|
@miroslavstastny thanks for the suggestion, I've added RTL examples (switch to RTL by default), and now when you maximize an example, if you were seeing the example in RTL the maximize example will also show it in rtl... Please take a look. |
added 3 commits
January 30, 2019 13:45
-changed order in gulp-example-menu
This was referenced Feb 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mechanism for adding rtl examples for visual test. The added test/examples should end with the extension
.rtl.tsx, and this is all that is necessary from developer's side (See the example for theDividerExample.rtl.tsx). Screener then will maximize this example with rtl enabled and will take screenshot of that.