Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

docs(screener-io): added documentation on how to write tests with steps #856

Merged
merged 7 commits into from
Feb 8, 2019

Conversation

silviuaavram
Copy link
Collaborator

Added documentation on how to write tests with the Screener Steps.

At the moment I added a draft change, and I think I can have some feedback while I also look to improve it.

@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #856   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          21       21           
  Lines         728      728           
  Branches       69       73    +4     
=======================================
  Hits          681      681           
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0d558...2f2623f. Read the comment docs.

.github/test-a-feature.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG 👍 thanks @silviuavram

Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.github/test-a-feature.md Outdated Show resolved Hide resolved

### Run Screener tests
In order to run the tests locally, make sure to have a Screener API key saved in the environment variables on your machine. For instance, on MacOS/Linux you can use `export SCREENER_API_KEY=<Your screener key here>`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what is for Windows? 🔍

This should work:

cross-env SCREENER_API_KEY=<Your screener key here> yarn test:visual

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups. will address this in my arrow navigation PR :)

@silviuaavram silviuaavram merged commit 2d74195 into master Feb 8, 2019
@layershifter layershifter deleted the docs/screener-test-runs branch February 8, 2019 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants