This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Popup): Focus the last focused element outside Popup on ESC #861
Merged
sophieH29
merged 6 commits into
master
from
fix/popup-triggered-by-menuitem-focuses-wrapper
Feb 8, 2019
Merged
fix(Popup): Focus the last focused element outside Popup on ESC #861
sophieH29
merged 6 commits into
master
from
fix/popup-triggered-by-menuitem-focuses-wrapper
Feb 8, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 7, 2019 14:33
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 69
=======================================
Hits 681 681
Misses 47 47 Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Feb 7, 2019
layershifter
reviewed
Feb 8, 2019
layershifter
reviewed
Feb 8, 2019
* Save DOM element which had focus before Popup opens. | ||
* Can be either trigger DOM element itself or the element inside it. | ||
*/ | ||
private updateTriggerFocusableDomElement() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to introduce a new method for a single use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense, don't want to mess up tryOpen
method and still remain better reading
Co-Authored-By: sophieH29 <8460706+sophieH29@users.noreply.github.com>
layershifter
approved these changes
Feb 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue when a complex component is used as a trigger for Popup, but actually, the inner element of that component triggers the Popup. So when press ESC on Popup, the focus should go to the actual focusable element which triggered the Popup, not the whole component itself.
In the next example,
MenuItem
is a trigger for the Popup and this component has this structureSo when press ESC,
MenuItem
's wrapper<li>
element will receive focus, instead of<a>
, what breaks focus management on the page.Closes #831