This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(dropdown): inline prop #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
added
question
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
commented
Feb 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 73 +4
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
layershifter
reviewed
Feb 8, 2019
docs/src/examples/components/Dropdown/Types/DropdownExampleInline.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Feb 8, 2019
packages/react/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Feb 8, 2019
packages/react/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Feb 8, 2019
packages/react/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
bmdalex
force-pushed
the
feat/dropdown-inline
branch
2 times, most recently
from
63d99fa
to
b6dd43c
Compare
mnajdova
reviewed
Feb 8, 2019
packages/react/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
mnajdova
reviewed
Feb 8, 2019
mnajdova
approved these changes
Feb 8, 2019
bmdalex
force-pushed
the
feat/dropdown-inline
branch
from
d697311
to
742d81e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(dropdown): inline prop
Description:
This PR implements the
inlineprop forDropdowncomponent.There will be a follow-up PR with a prototype on how to handle the inline Dropdown in the context of a rich text editor
API
Styling