Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(teams-theme): replace margins with padding in chatItemStyles (Teams theme) #878

Merged
merged 4 commits into from
Feb 14, 2019

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Feb 11, 2019

Replace margins with padding in chatItemStyles for Teams theme, for correct calculation of the height when using it together with virtualized lists.

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #878 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #878   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files         648      648           
  Lines        8334     8334           
  Branches     1484     1484           
=======================================
  Hits         6717     6717           
  Misses       1602     1602           
  Partials       15       15
Impacted Files Coverage Δ
...src/themes/teams/components/Chat/chatItemStyles.ts 38.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad29058...b74a42c. Read the comment docs.

@layershifter layershifter changed the title feat(teams-theme): replace margins with padding in chatItemStyles (Teams theme) fix(teams-theme): replace margins with padding in chatItemStyles (Teams theme) Feb 11, 2019
@layershifter layershifter added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. labels Feb 14, 2019
@mnajdova mnajdova merged commit f9a6b39 into master Feb 14, 2019
@layershifter layershifter deleted the fix/teams-theme-chat-styles-update branch February 19, 2019 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants