This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Provider): temporarily disable consumer typings #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov and
mnajdova
as code owners
levithomason
force-pushed
the
fix/provider-typings
branch
from
9c6b3a1
to
f515664
Compare
kuzhelov
approved these changes
Aug 13, 2018
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 39 39
Lines 664 664
Branches 90 99 +9
=======================================
Hits 573 573
Misses 88 88
Partials 3 3
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a temporary workaround to #87.
Workaround
This branch temporarily removes the Consumer's typings which also sidesteps the bug for now. There is a TODO linked to the GitHub issue for later resolution.
Proper Fix
In #89, we're adding a proper project build test that will consume the dist directory and ensure the project will compile.