Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

chore(package): update fela #894

Merged
merged 2 commits into from
Feb 13, 2019
Merged

chore(package): update fela #894

merged 2 commits into from
Feb 13, 2019

Conversation

layershifter
Copy link
Member

No more const enum

Fixes #613, see robinweser/fela#671.

Fixed animations in RTL

Fixes #516.

Before

animation-before

After

animation-after

devMode is working correctly

Fixes #782.

devmode

@layershifter layershifter added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. labels Feb 13, 2019
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #894 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #894   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files          21       21           
  Lines         728      728           
  Branches       69       69           
=======================================
  Hits          677      677           
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13c435...f675eb6. Read the comment docs.

Copy link
Contributor

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for addressing the issues on fela's side :)

@layershifter layershifter merged commit 8f590a4 into master Feb 13, 2019
@layershifter layershifter deleted the chore/update-fela branch February 13, 2019 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants