Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(ChatMessage): prevent hover over invisible actions area #953

Merged
merged 9 commits into from
Feb 26, 2019

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Feb 22, 2019

TODO

  • update changelog

This PR fixes undesired effect when actions menu is showed up while user hovering over invisible to her area. This has resulted in weird user experience (consider on-hover appearance of actions menu for the lower chat message):

chat-message-problem

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Feb 22, 2019

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #953 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage    80.5%   80.51%   +<.01%     
==========================================
  Files         659      659              
  Lines        8450     8447       -3     
  Branches     1493     1428      -65     
==========================================
- Hits         6803     6801       -2     
+ Misses       1632     1631       -1     
  Partials       15       15
Impacted Files Coverage Δ
.../themes/teams/components/Chat/chatMessageStyles.ts 23.8% <ø> (ø) ⬆️
...ackages/react/src/components/Dropdown/Dropdown.tsx 34.13% <0%> (ø) ⬆️
packages/react/src/components/Input/Input.tsx 100% <0%> (ø) ⬆️
packages/react/src/index.ts 100% <0%> (ø) ⬆️
...ct/src/components/Dropdown/DropdownSearchInput.tsx 48.14% <0%> (ø) ⬆️
...themes/teams/components/Dropdown/dropdownStyles.ts 24.13% <0%> (ø) ⬆️
packages/react/src/lib/felaRenderer.tsx 100% <0%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72eab06...66b93ae. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #953 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
- Coverage   80.96%   80.94%   -0.02%     
==========================================
  Files         664      664              
  Lines        8496     8498       +2     
  Branches     1431     1433       +2     
==========================================
  Hits         6879     6879              
- Misses       1602     1604       +2     
  Partials       15       15
Impacted Files Coverage Δ
.../themes/teams/components/Chat/chatMessageStyles.ts 20% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8519c74...9b14018. Read the comment docs.

@jurokapsiar
Copy link
Contributor

focus and hover styles (when you hover on the right edge of the message) are broken after the change:

image

@kuzhelov
Copy link
Contributor Author

kuzhelov commented Feb 25, 2019

@jurokapsiar, thanks a lot for spotting that - have updated styles to address these issues:

chat-message-problem

submenu's accessibility

chat-message-problem

Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget about a changelog entry 🐱

@kuzhelov kuzhelov merged commit 3063655 into master Feb 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/hover-over-invisible-actions-menu branch February 26, 2019 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants