This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(docs): createComponent typings and documentation #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
added
🚀 ready for review
🧰 fix
Introduces fix for broken behavior.
📚 docs
labels
Feb 22, 2019
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
February 22, 2019 17:08
bmdalex
commented
Feb 22, 2019
bmdalex
force-pushed
the
fix/docs-create-component-interfaces
branch
from
February 22, 2019 17:17
40304ac
to
fc4c93f
Compare
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
=======================================
Coverage 80.96% 80.96%
=======================================
Files 665 665
Lines 8504 8504
Branches 1497 1433 -64
=======================================
Hits 6885 6885
Misses 1604 1604
Partials 15 15
Continue to review full report at Codecov.
|
bmdalex
force-pushed
the
fix/docs-create-component-interfaces
branch
from
February 22, 2019 17:18
fc4c93f
to
9f91516
Compare
bmdalex
changed the title
fix(docs): createComponent interfaces
fix(docs): createComponent interfaces and documentation
Feb 22, 2019
bmdalex
force-pushed
the
fix/docs-create-component-interfaces
branch
from
February 22, 2019 17:20
9f91516
to
169f834
Compare
bmdalex
changed the title
fix(docs): createComponent interfaces and documentation
fix(docs): createComponent typings and documentation
Feb 22, 2019
alinais
approved these changes
Feb 26, 2019
bmdalex
force-pushed
the
fix/docs-create-component-interfaces
branch
from
February 26, 2019 11:30
7949226
to
1877708
Compare
kuzhelov
reviewed
Feb 26, 2019
bmdalex
force-pushed
the
fix/docs-create-component-interfaces
branch
2 times, most recently
from
February 26, 2019 14:31
2e60697
to
8df78a5
Compare
kuzhelov
approved these changes
Feb 26, 2019
bmdalex
force-pushed
the
fix/docs-create-component-interfaces
branch
from
February 26, 2019 15:03
eda5cee
to
29b0821
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(docs): createComponent typings and documentation
FIxes #946 by:
createComponent
/integrate-custom-components
section in Documentation