Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(docs): createComponent typings and documentation #954

Merged
merged 4 commits into from
Feb 26, 2019

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Feb 22, 2019

fix(docs): createComponent typings and documentation

FIxes #946 by:

  • improving typings for createComponent
  • improving /integrate-custom-components section in Documentation

@bmdalex bmdalex force-pushed the fix/docs-create-component-interfaces branch from 40304ac to fc4c93f Compare February 22, 2019 17:17
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #954 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #954   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         665      665           
  Lines        8504     8504           
  Branches     1497     1433   -64     
=======================================
  Hits         6885     6885           
  Misses       1604     1604           
  Partials       15       15
Impacted Files Coverage Δ
packages/react/src/lib/createComponent.tsx 100% <100%> (ø) ⬆️
packages/react/src/lib/createStardustComponent.tsx 30.76% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45df254...29b0821. Read the comment docs.

@bmdalex bmdalex force-pushed the fix/docs-create-component-interfaces branch from fc4c93f to 9f91516 Compare February 22, 2019 17:18
@bmdalex bmdalex changed the title fix(docs): createComponent interfaces fix(docs): createComponent interfaces and documentation Feb 22, 2019
@bmdalex bmdalex force-pushed the fix/docs-create-component-interfaces branch from 9f91516 to 169f834 Compare February 22, 2019 17:20
@bmdalex bmdalex changed the title fix(docs): createComponent interfaces and documentation fix(docs): createComponent typings and documentation Feb 22, 2019
@bmdalex bmdalex force-pushed the fix/docs-create-component-interfaces branch from 7949226 to 1877708 Compare February 26, 2019 11:30
@bmdalex bmdalex force-pushed the fix/docs-create-component-interfaces branch 2 times, most recently from 2e60697 to 8df78a5 Compare February 26, 2019 14:31
@bmdalex bmdalex force-pushed the fix/docs-create-component-interfaces branch from eda5cee to 29b0821 Compare February 26, 2019 15:03
@bmdalex bmdalex merged commit 6d90064 into master Feb 26, 2019
@bmdalex bmdalex deleted the fix/docs-create-component-interfaces branch February 26, 2019 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📚 docs 🧰 fix Introduces fix for broken behavior. ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong documentation for createComponent
3 participants