This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(ChatMessage): styles #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kuzhelov
added
🧰 fix
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=========================================
- Coverage 80.72% 80.7% -0.02%
=========================================
Files 659 659
Lines 8457 8459 +2
Branches 1429 1431 +2
=========================================
Hits 6827 6827
- Misses 1616 1618 +2
Partials 14 14
Continue to review full report at Codecov.
|
mnajdova
reviewed
Feb 25, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Feb 25, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Feb 25, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Feb 25, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
bmdalex
reviewed
Feb 25, 2019
packages/react/src/themes/teams/components/Chat/chatMessageStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Feb 25, 2019
| marginLeft: p.mine ? marginOffset : 0, | ||
| marginRight: !p.mine ? marginOffset : 0, | ||
| maxWidth: `calc(100% - ${marginOffset})`, | ||
| minWidth: marginOffset, |
There was a problem hiding this comment.
Would introduce the marginOffset as a variable, but it is used as minWidth as well, which will mean maybe we need variables... Just thinking out loud :) Maybe it's better if it stays as it is..
mnajdova
approved these changes
Feb 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.