This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
export call-pstn-full and sfb-viewbox icons
#968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewulf7
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
- Coverage 81.64% 81.54% -0.11%
==========================================
Files 675 677 +2
Lines 8756 8766 +10
Branches 1492 1558 +66
==========================================
- Hits 7149 7148 -1
- Misses 1592 1602 +10
- Partials 15 16 +1
Continue to review full report at Codecov.
|
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
from
54a59b7
to
0f7f488
Compare
|
changes look fine to me - @codepretty, could you, please, take final look on the names of the exported icons? |
kuzhelov
reviewed
Feb 26, 2019
|
@thewulf7, icons were checked against spec, there is nothing blocking this PR - lets merge recent master into this branch, resolve CHANGELOG conflicts and merge right after 👍 |
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
3 times, most recently
from
63eb86f
to
7294286
Compare
kuzhelov
reviewed
Feb 28, 2019
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-pstn-full.tsx
Show resolved
Hide resolved
kuzhelov
approved these changes
Feb 28, 2019
bmdalex
approved these changes
Feb 28, 2019
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
2 times, most recently
from
7b0bbc6
to
dbdc12d
Compare
codepretty
reviewed
Feb 28, 2019
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-sfb-viewbox-32.tsx
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Feb 28, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/callPstn.tsx
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Feb 28, 2019
codepretty
reviewed
Feb 28, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/sfbViewbox.tsx
Outdated
Show resolved
Hide resolved
codepretty
reviewed
Feb 28, 2019
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-pstn.tsx
Show resolved
Hide resolved
codepretty
added
needs author changes
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
from
dbdc12d
to
f185874
Compare
codepretty
approved these changes
Mar 6, 2019
codepretty
removed
the
needs author changes
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
from
cef0ccb
to
f3acb71
Compare
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
from
f3acb71
to
afc5821
Compare
mnajdova
reviewed
Mar 7, 2019
| import * as React from 'react' | ||
| import cx from 'classnames' | ||
| import { TeamsProcessedSvgIconSpec } from '../types' | ||
| import { teamsIconClassNames } from 'src/themes/teams/components/Icon/svg' |
There was a problem hiding this comment.
change this with relative import
thewulf7
force-pushed
the
feat/icon_pstn-full-sbf
branch
from
afc5821
to
f73d7b7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exports
call-pstn-fullandsfb-viewboxicons