Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(button group): revert margin update #973

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Conversation

bmdalex
Copy link
Collaborator

@bmdalex bmdalex commented Feb 26, 2019

fix(button group): revert margin update

Description

This PR fixes a small regression in the spacing of Button.Group component items, introduced #945

Screenshots

Before:

screenshot 2019-02-26 at 16 22 02

After:

screenshot 2019-02-26 at 16 22 12

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #973 into master will decrease coverage by 0.17%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   80.96%   80.78%   -0.18%     
==========================================
  Files         665      665              
  Lines        8504     8504              
  Branches     1433     1433              
==========================================
- Hits         6885     6870      -15     
- Misses       1604     1620      +16     
+ Partials       15       14       -1
Impacted Files Coverage Δ
...ckages/react/src/components/Button/ButtonGroup.tsx 97.22% <ø> (-0.08%) ⬇️
...hemes/teams/components/Button/buttonGroupStyles.ts 36.36% <66.66%> (+6.36%) ⬆️
packages/react/src/components/Flex/Flex.tsx 50% <0%> (-44.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f899587...73fad03. Read the comment docs.

@bmdalex bmdalex merged commit 109d501 into master Feb 26, 2019
@bmdalex bmdalex deleted the fix/button-group-spacing branch February 26, 2019 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants