This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): Do not propagate keydown events outside Popup's content #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
=========================================
+ Coverage 81.08% 81.1% +0.01%
=========================================
Files 671 671
Lines 8625 8627 +2
Branches 1456 1520 +64
=========================================
+ Hits 6994 6997 +3
+ Misses 1616 1615 -1
Partials 15 15
Continue to review full report at Codecov.
|
…ithub.com/stardust-ui/react into fix/popup-do-not-propagate-keydown-events # Conflicts: # CHANGELOG.md
layershifter
added
needs author changes
sophieH29
added
🚀 ready for review
and removed
needs author changes
layershifter
approved these changes
Mar 1, 2019
delete-merged-branch
bot
deleted the
fix/popup-do-not-propagate-keydown-events
branch
mnajdova
reviewed
Mar 6, 2019
| @@ -439,8 +438,12 @@ export default class Popup extends AutoControlledComponent<ReactProps<PopupProps | |||
| const popupWrapperAttributes = { | |||
| ...(rtl && { dir: 'rtl' }), | |||
| ...accessibility.attributes.popup, | |||
| ...accessibility.keyHandlers.popup, | |||
|
|
|||
| onKeyDown: (e: React.KeyboardEvent) => { | |||
There was a problem hiding this comment.
I know it is too late now, but I was just wondering whether our suggestion for the users would have been override the onKeyDown for the Popup and stop propagating if you want? This seem too much specific to the client's needs that we had at that moment.. @layershifter @sophieH29
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #978
No need to propagate keydown events outside Popup, allow only keyboard actions to execute