This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(shorthands): allow arrays as shorthand value #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
+ Coverage 81.34% 81.39% +0.05%
==========================================
Files 673 673
Lines 8666 8692 +26
Branches 1467 1471 +4
==========================================
+ Hits 7049 7075 +26
Misses 1602 1602
Partials 15 15
Continue to review full report at Codecov.
|
mnajdova
changed the title
layershifter
reviewed
Mar 1, 2019
docs/src/examples/components/Chat/Content/ChatExampleReactionGroup.shorthand.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Mar 1, 2019
|
I like the idea with object config, we can apply it to other factories ( |
It's not enough to close the matching issue 😸 |
added 3 commits
March 1, 2019 15:04
kuzhelov
reviewed
Mar 1, 2019
| @@ -90,6 +90,6 @@ class AccordionTitle extends UIComponent<ReactProps<AccordionTitleProps>, any> { | |||
| } | |||
| } | |||
|
|
|||
| AccordionTitle.create = createShorthandFactory(AccordionTitle, 'content') | |||
| AccordionTitle.create = createShorthandFactory({ Component: AccordionTitle, mappedProp: 'content' }) | |||
added 3 commits
March 1, 2019 16:51
-reverted changes for the reactions
mnajdova
commented
Mar 1, 2019
| Component: React.ReactType | ||
| mappedProp?: string | ||
| mappedArrayProp?: string | ||
| valueOrRenderCallback?: ShorthandValue | ShorthandRenderCallback |
There was a problem hiding this comment.
Not sure about this name here... Would rather have value, as it is much simpler and shorter...
layershifter
reviewed
Mar 4, 2019
layershifter
approved these changes
Mar 4, 2019
added 3 commits
March 4, 2019 13:59
…shorthand-factory # Conflicts: # packages/react/src/components/Dropdown/DropdownSearchInput.tsx
packages/react/src/lib/factories.ts
Outdated
| @@ -119,19 +149,21 @@ function createShorthandFromValue( | |||
|
|
|||
| const valIsPrimitive = typeof value === 'string' || typeof value === 'number' | |||
| const valIsPropsObject = _.isPlainObject(value) | |||
| const valIsArrayObject = _.isArray(value) | |||
There was a problem hiding this comment.
Will change it to valueIsArray :)
added 2 commits
March 4, 2019 16:06
delete-merged-branch
bot
deleted the
feat/allow-arrays-as-shorthands-in-create-shorthand-factory
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #984 by allowing arrays to be used together with the shortand props which are representing collection.