Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot log to Tensorboard because of automatic folder name #75

Closed
PhilMacKay opened this issue Dec 4, 2019 · 2 comments
Closed

Cannot log to Tensorboard because of automatic folder name #75

PhilMacKay opened this issue Dec 4, 2019 · 2 comments

Comments

@PhilMacKay
Copy link
Contributor

When using Tensorboard logging, it will try to create a directory with time_str = datetime.now().isoformat()[:-7].replace("T", " ").
However, the isoformat includes the ":" character which cannot be used in a file path.

The line should be updated to replace a blacklist of characters. This may vary from one OS to another, but on Windows 10, it's not possible to use Tensorboard logging without tweaking the time_str variable.

@stared
Copy link
Owner

stared commented Dec 21, 2019

@PhilMacKay Thank you for bringing this issue (I tested it on macOS and Ubuntu, but not Windows).

Yes, it is likely system dependent. If you create a PR solving that issue (e.g. .replace(":", "_")), I will gladly accept that.

@stared
Copy link
Owner

stared commented Jan 13, 2020

Solved with #77.

@stared stared closed this as completed Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants