Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore PR #20 as the build error is now fixed #23

Closed
wants to merge 2 commits into from

Conversation

psqli
Copy link
Contributor

@psqli psqli commented Nov 16, 2021

The commit 85c3f51 ("Allow building and installing without any vendored dependencies") resulted in Makefile's py_vendor target failing when one of pip install exited with an error. However, pip install was already returning errors. The target all depended on py_vendor, and this ended up failing the build.

The commit c93792e ("Makefile: More modular targets") removed the py_vendor as build dependency. Now the automated build is working again.

@psqli
Copy link
Contributor Author

psqli commented Nov 16, 2021

For my tests, I've added a commit to disable automatic build on push (f9f68f0). With this commit, build must be done manually via Actions tab. I left the commit in the pull request. Do you prefer this behavior (manual build) or the previous (build on push/PR)?

@psqli
Copy link
Contributor Author

psqli commented Nov 16, 2021

I just noticed that there are two successful builds after c93792e (just before you reverted #20)

:-)

image

@ghost
Copy link

ghost commented Nov 17, 2021

Good catch. That was some unrelated work for distro packagers to vendor all of the Python dependencies, so it would appear this was caused by the build machines not having internet access, which is no longer an issue.

I am fine with merging this, as soon as we fix the other issue: dpkg-name should only be used if explicitly requested by a CLI argument, because it creates packages named only stargate_21.12.3_amd64.deb, which I then have to rename by hand when creating releases to upload for Ubuntu, Debian and Raspbian. But, the daily packages should have a completely different name than the release packages, something like:

stargate-daily-21.11.4-abc1234-amd64.deb

Where abc1234 is the commit hash.

@ghost ghost closed this Dec 3, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant