Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grain scene asset modification generation trigger #64

Closed
lucasmontec opened this issue Aug 9, 2023 · 3 comments · Fixed by #82
Closed

Fine-grain scene asset modification generation trigger #64

lucasmontec opened this issue Aug 9, 2023 · 3 comments · Fixed by #82
Assignees
Labels
enhancement New feature or request

Comments

@lucasmontec
Copy link

Hey, another recommendation here!
Currently, the regeneration of the map is defaulted to a setup that occurs whenever I save a scene. This causes it to add info to the console (default setting for the asset is debug logging level) every time I save a scene.
I believe two changes would be great, one is defaulting to warning, not debug.
Another is to listen to scene files being created/deleted instead of each change/save, to generate.
You can add hooks for OnWillDeleteAsset and OnWillCreateAsset.

Sorry if you considered this already. It's just that I work with a very pedant team and the console 'spam' got to them more than the value your plugin generates, which is crazy for me.
Still, amazing work! I hope I'm helping giving suggestions.

@starikcetin
Copy link
Owner

starikcetin commented Aug 9, 2023

Thank you for your suggestion. Yes, I am considering fine-graining the scene modification trigger. It tends to get spammy.

Also, yes, I appreciate every suggestion I receive. Hearing people's input helps me get a better perspective.

@starikcetin starikcetin changed the title Generation spams console by default Fine-grain scene asset modification generation trigger Aug 9, 2023
@starikcetin starikcetin added the enhancement New feature or request label Aug 9, 2023
@starikcetin starikcetin self-assigned this Aug 10, 2023
@starikcetin
Copy link
Owner

Fixed in #82. Will be included in the next release.

@starikcetin
Copy link
Owner

Included in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants