Skip to content
This repository has been archived by the owner on May 8, 2018. It is now read-only.

Add Google templates #2

Merged
merged 1 commit into from Oct 31, 2016
Merged

Add Google templates #2

merged 1 commit into from Oct 31, 2016

Conversation

frodenas
Copy link
Contributor

This PR upgrades Bolo release to v0.2.3 and adds Google templates. It also removes the genesis binary (it was pretty outdated) and assumes you already have it installed somewhere in your PATH (similar to other genesis *-deployments).

@jhunt
Copy link
Contributor

jhunt commented Sep 11, 2016

The genesis binary should be updated, not removed. It is embedded so that it works with Concourse pipelines.

Either that, or cloning a new deployment needs to embed the calling Genesis.

@frodenas
Copy link
Contributor Author

So why shield-deployment, concourse-deployment, vault-deployment & bosh-lite-deployment don't have it embedded?

@frodenas
Copy link
Contributor Author

Trying to understand the pattern, I'm a newbie :)

@geofffranks
Copy link
Contributor

genesis does embed when creating new repos from scratch or via templates, so this shouldn't be a concern.

@frodenas can you fix the merge conflicts and we'll get this merged?

@frodenas
Copy link
Contributor Author

@geofffranks Done.

@jhunt
Copy link
Contributor

jhunt commented Oct 31, 2016

Thanks!

@jhunt jhunt merged commit 8297eed into master Oct 31, 2016
@jhunt jhunt deleted the google branch October 31, 2016 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants