refactor: future-proof getInstalledWallets
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wallet's |
|
sure, thanks, that was just a question. this pr shouldn't have an impact on ids |
avimak
reviewed
May 24, 2022
src/index.ts
Outdated
| ["starknet", "starknet_braavos", ...Object.keys(window)].reduce<{ | ||
| [key: string]: IStarknetWindowObject; | ||
| }>((wallets, key) => { | ||
| Object.getOwnPropertyNames(window).reduce((wallets, key) => { |
There was a problem hiding this comment.
pls declare Record<string, IStarknetWindowObject> here - directly on the reduce - instead of using as over line 282
avimak
approved these changes
May 24, 2022
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future starknet wallets should be automatically handled using this method, independent of the way they're set on the
windowobject.A question remains: what if multiple wallets don't define an
id? Currently only one of them would be keyed as "undefined" in thiswalletsobject, overwriting the others. Since the key set onwindowis already unique for each wallet, why not use that as identifier?