• components/discount/discountCheckoutScreen.tsx (3 hunks)
• components/discount/discountOfferScreenVariant.tsx (1 hunks)
• components/discount/registerDiscount.tsx (9 hunks)
• components/domains/registerSummary.tsx (3 hunks)
• pages/domain-gift.tsx (1 hunks)
• styles/discount.module.css (4 hunks)
• types/frontTypes.d.ts (1 hunks)
• utils/discounts/domainGift.ts (1 hunks)

• components/discount/discountCheckoutScreen.tsx
• components/discount/discountOfferScreenVariant.tsx
• styles/discount.module.css
• utils/discounts/domainGift.ts

pages/domain-gift.tsx (3)

26-58: Review the conditional rendering logic for different screens.

The conditional rendering based on the screen state is implemented correctly. Each condition correctly renders a specific component for different states of the domain gift campaign.

---

11-62: Ensure proper handling of undefined or null values in state and props.

While the code generally looks good, it's crucial to ensure that all props, especially those from domainGift, handle potential undefined or null values gracefully to prevent runtime errors.

---

19-19: Verify the logic for setting the screen based on the campaign expiry.

The logic to set the screen to 0 when the current timestamp is greater than or equal to domainGift.expiry seems correct. However, ensure that the domainGift.expiry is always a valid date and consider what should happen right at the moment of expiry.

Verification successful

---

The domainGift.expiry is initialized in utils/discounts/domainGift.ts with a hardcoded timestamp value. This ensures that domainGift.expiry is always a valid date. The logic to set the screen to 0 when the current timestamp is greater than or equal to domainGift.expiry is correct and should work as intended.

• utils/discounts/domainGift.ts:

  export const domainGift: DomainGift = {
    name: "Domain Gift",
    image: "/register/gift.webp",
    expiry: 1726382280 * 1000, // timestamp in ms
    discountMailGroupId: "X",
    offer: {
      // offer details
    }
  };

• pages/domain-gift.tsx:

  useEffect(() => {
    const currentDate = new Date();
    const timestamp = currentDate.getTime();
  
    if (timestamp >= domainGift.expiry) setScreen(0);
  }, []);

The initialization ensures that domainGift.expiry is always a valid timestamp, and the logic in the useEffect hook correctly handles the expiry check.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the handling of campaign expiry in DomainGift component.

# Test: Search for usage of `domainGift.expiry`. Expect: Proper date handling and edge cases considered.
rg --type typescript $'domainGift\\.expiry'

Length of output: 78

---

---

Script:

#!/bin/bash
# Description: Verify the handling of campaign expiry in DomainGift component.

# Test: Search for usage of `domainGift.expiry`. Expect: Proper date handling and edge cases considered.
rg --type ts 'domainGift\.expiry'

Length of output: 170

---

---

Script:

#!/bin/bash
# Extract lines around the first occurrence of `domainGift.expiry` in `pages/domain-gift.tsx`
rg --type ts --context 5 'domainGift\.expiry' pages/domain-gift.tsx

Length of output: 674

---

---

Script:

#!/bin/bash
# Search for the initialization and validation of `domainGift.expiry`
rg --type ts 'domainGift\s*=\s*{[^}]*expiry' --context 5

Length of output: 188

---

---

Script:

#!/bin/bash
# Search for the initialization and validation of `domainGift.expiry`
rg --type ts 'domainGift\s*=\s*{[^}]*expiry' --context 5

Length of output: 188

---

---

Script:

#!/bin/bash
# Search for the initialization of `domainGift` and manually inspect for `expiry`
rg --type ts 'domainGift\s*=' --context 5

Length of output: 43

---

---

Script:

#!/bin/bash
# Search for any initialization or assignment to `domainGift` across all TypeScript files
rg --type ts 'domainGift' --context 5

Length of output: 3847

types/frontTypes.d.ts (1)

59-62: Ensure consistency in the use of optional properties in the Discount type.

The addition of couponCode and couponHelper as optional properties in the Discount type is consistent with the updates in the component props. This ensures type safety and better integration with the updated components.

components/domains/registerSummary.tsx (2)

155-165: Review the conditional rendering logic for displaying price information.

The conditional rendering based on the isFree prop is implemented correctly. It either displays "Free" or the calculated token price, ensuring a clear and accurate presentation of cost information to the user.

---

32-32: Validate the default value and usage of the isFree prop.

The isFree prop is used to conditionally render the registration cost as "Free". Ensure that this prop is always passed correctly from parent components and consider providing a default value in the prop destructuring to handle cases where it might not be provided.

Also applies to: 50-50

Verification successful

---

The isFree prop in registerSummary.tsx is correctly provided with a default value of false and is used consistently in conditional rendering.

• components/domains/registerSummary.tsx:
  • Line 32: isFree?: boolean;
  • Line 50: isFree = false,
  • Line 54: {isFree ? (
  • Line 58: {isFree ? null : areArCurrenciesEnabled ? (

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the handling and default value of `isFree` prop in RegisterSummary component.

# Test: Search for usage of `isFree` prop. Expect: Default value provided and used consistently.
rg --type typescript $'isFree'

Length of output: 64

---

---

Script:

#!/bin/bash
# Description: Verify the handling and default value of `isFree` prop in RegisterSummary component.

# Test: Search for usage of `isFree` prop. Expect: Default value provided and used consistently.
rg --type ts 'isFree'
rg --type tsx 'isFree'

Length of output: 485

components/discount/registerDiscount.tsx (3)

333-336: Review the implementation of the changeCoupon function.

The changeCoupon function correctly updates the coupon state and sets couponError based on whether the coupon value is empty. This ensures proper validation and user feedback.

---

388-398: Validate the conditional rendering and error handling for the coupon code input.

The conditional rendering based on the couponCode prop and the error handling for the coupon input are implemented correctly. This ensures that the coupon code feature is optional and that errors are handled appropriately.

---

52-54: Ensure proper handling and default values for new props in RegisterDiscount.

The new props couponCode, couponHelper, and banner are used to enhance the component's functionality. Verify that these props are always provided when the component is used, or consider setting sensible default values.

Also applies to: 65-67

• components/discount/discountCheckoutScreen.tsx (4 hunks)
• components/discount/registerDiscount.tsx (12 hunks)
• pages/domain-gift.tsx (1 hunks)
• utils/campaignService.ts (1 hunks)

• components/discount/discountCheckoutScreen.tsx
• pages/domain-gift.tsx

components/discount/registerDiscount.tsx (1)

61-64: Ensure correct prop types for couponCode, couponHelper, and banner.

Check if couponCode should be a boolean (as defined) or if it should be a string or other type based on its usage in the component.

Verification successful

---

Ensure correct prop types for couponCode, couponHelper, and banner.

The prop types for couponCode, couponHelper, and banner in the RegisterDiscountProps interface are correctly defined as boolean, string, and string respectively. Their usage within the component aligns with these types:

• couponCode is used in a conditional rendering, which is appropriate for a boolean.

• couponHelper is assigned to helperText, which is appropriate for a string.

• banner is used as the src attribute of an img tag, which is appropriate for a string.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify that the prop types for `couponCode`, `couponHelper`, and `banner` are correctly used throughout the component.

# Test: Search for prop usage in the component.
ast-grep --lang javascript --pattern $'const RegisterDiscount: FunctionComponent<RegisterDiscountProps> = ($_) {
  $$$
  $_($_)
}'

Length of output: 644

---

---

Script:

#!/bin/bash
# Description: Verify that the prop types for `couponCode`, `couponHelper`, and `banner` are correctly used throughout the component.

# Test: Search for prop usage in the component.
ast-grep --lang typescript --pattern 'const RegisterDiscount: FunctionComponent<$_> = ($$) => { $$$ }'

Length of output: 104

---

---

Script:

#!/bin/bash
# Description: Verify the prop types for `couponCode`, `couponHelper`, and `banner` in the `RegisterDiscountProps` interface and their usage in the component.

# Step 1: Search for the `RegisterDiscountProps` interface definition.
ast-grep --lang typescript --pattern 'interface RegisterDiscountProps { $$$ }'

# Step 2: Verify the usage of `couponCode`, `couponHelper`, and `banner` within the component.
rg 'couponCode|couponHelper|banner' components/discount/registerDiscount.tsx

Length of output: 416

• components/discount/discountOfferScreenVariant.tsx (1 hunks)

• components/discount/discountOfferScreenVariant.tsx

• components/discount/discountCheckoutScreen.tsx (3 hunks)
• components/discount/freeRegisterDiscount.tsx (1 hunks)
• components/discount/registerDiscount.tsx (12 hunks)
• pages/freeregistration.tsx (1 hunks)
• pages/quantumleap.tsx (2 hunks)
• utils/callData/registrationCalls.ts (2 hunks)
• utils/campaignService.ts (1 hunks)
• utils/discounts/freeRegistration.ts (1 hunks)

• utils/callData/registrationCalls.ts (no review received)
• components/discount/registerDiscount.tsx (no review received)

• utils/discounts/freeRegistration.ts

• components/discount/discountCheckoutScreen.tsx
• utils/campaignService.ts

components/discount/freeRegisterDiscount.tsx (2)

28-49: The component structure and JSX are well-organized and readable.

---

6-12: Ensure SearchResult type is properly defined and imported.

pages/freeregistration.tsx (2)

28-66: The page component handles different screens effectively using conditional rendering.

---

17-22: Ensure that the campaign expiry logic is correctly implemented and tested.

Verification successful

---

The search results indicate that freeRegistration.expiry is used in two places within pages/freeregistration.tsx:

• Line 17: In the useEffect hook to check if the current timestamp is greater than or equal to the expiry.
• Line 22: As a prop in a JSX element.

Both usages appear to be consistent with the intended functionality of checking and displaying the campaign expiry. The logic seems correctly implemented.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the campaign expiry logic.

# Test: Search for the usage of `freeRegistration.expiry` in the codebase.
rg --type typescript $'freeRegistration.expiry'

Length of output: 81

---

---

Script:

#!/bin/bash
# Description: Verify the campaign expiry logic.

# Test: Search for the usage of `freeRegistration.expiry` in the codebase.
rg --type ts $'freeRegistration.expiry'

Length of output: 195

pages/quantumleap.tsx (2)

89-102: The component structure and JSX are well-organized and readable.

---

89-102: Ensure that the RegisterDiscount component is correctly integrated and receiving all required props.

Verification successful

---

The RegisterDiscount component is correctly integrated and receiving all required props in pages/quantumleap.tsx. The props passed to RegisterDiscount in QuantumLeap match the expected RegisterDiscountProps type defined in components/discount/registerDiscount.tsx.

• domain: searchResult?.name ?? ""
• duration: getDuration()
• discountId: getDiscountId()
• customMessage: getCustomMessage()
• priceInEth: getPrice()
• mailGroups: [process.env.NEXT_PUBLIC_MAILING_LIST_GROUP ?? "", quantumLeapDiscount.discountMailGroupId]
• goBack: goBack

No issues were found with the integration.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the integration of `RegisterDiscount` component.

# Test: Search for the usage of `RegisterDiscount` in the codebase.
rg --type typescript $'RegisterDiscount'

Length of output: 74

---

---

Script:

#!/bin/bash
# Description: Verify the integration of `RegisterDiscount` component.

# Test: Search for the usage of `RegisterDiscount` in the codebase.
rg --type ts,tsx 'RegisterDiscount'

Length of output: 66

---

---

Script:

#!/bin/bash
# Description: Verify the integration of `RegisterDiscount` component.

# Test: Search for the usage of `RegisterDiscount` in the codebase.
rg --type ts 'RegisterDiscount'
rg --type tsx 'RegisterDiscount'

Length of output: 1262

---

---

Script:

#!/bin/bash
# Description: Extract relevant portions of files for `RegisterDiscount` integration review.

# Extract the relevant portion from `pages/quantumleap.tsx`.
rg --type ts 'RegisterDiscount' pages/quantumleap.tsx -A 10 -B 10

# Extract the relevant portion from `components/discount/registerDiscount.tsx`.
rg --type ts 'RegisterDiscount' components/discount/registerDiscount.tsx -A 10 -B 10

Length of output: 3028

Files that changed from the base of the PR and between baf51ff and 2061244.

• utils/callData/registrationCalls.ts (2 hunks)

utils/callData/registrationCalls.ts (1)

224-224: Consider removing the unnecessary flat() method.

- calldata: [newTokenId, encodedDomain, signature, txMetadataHash].flat(),
+ calldata: [newTokenId, encodedDomain, ...signature, txMetadataHash],

The array [newTokenId, encodedDomain, signature, txMetadataHash] is already flat, and signature is spread into the array to ensure all elements are at the same level.

Files that changed from the base of the PR and between 2061244 and 8177da2.

• components/discount/FreeRegisterPresentation.tsx (1 hunks)
• components/discount/freeRenewalDiscount.tsx (3 hunks)
• components/discount/freeRenewalPresentation.tsx (2 hunks)
• components/discount/registerFree.tsx (1 hunks)
• pages/freeregistration.tsx (1 hunks)
• pages/freerenewal.tsx (3 hunks)
• tests/utils/campaignService.test.js (1 hunks)

• pages/freeregistration.tsx
• tests/utils/campaignService.test.js

pages/freerenewal.tsx (2)

36-36: Verify the correct handling of the setScreen function.

Ensure that the setScreen function correctly handles the screen state transitions, especially in edge cases where the state might not update as expected.

---

46-46: Review the use of environment variables and group IDs.

Ensure that the environment variable NEXT_PUBLIC_MAILING_LIST_GROUP_AUTO_RENEWAL is used consistently and securely throughout the codebase.

Files that changed from the base of the PR and between 8177da2 and e2a19d0.

• components/discount/freeRegisterCheckout.tsx (1 hunks)
• components/discount/freeRegisterPresentation.tsx (1 hunks)
• pages/freeregistration.tsx (1 hunks)
• styles/components/registerV2.module.css (1 hunks)
• utils/discounts/freeRegistration.ts (1 hunks)

• styles/components/registerV2.module.css

• pages/freeregistration.tsx
• utils/discounts/freeRegistration.ts

components/discount/freeRegisterPresentation.tsx (3)

7-14: The addition of the expiry prop is well-integrated and aligns with the PR objectives to include an expiry timer in the UI.

---

16-49: The main function logic for handling search results and screen transitions is clear and effective.

---

24-49: The JSX structure is well-organized, effectively using conditional rendering and integrating the Timer component. Styling with CSS modules enhances maintainability.

components/discount/freeRegisterCheckout.tsx (1)

25-33: The addition of couponCode and couponHelper props supports the new functionality of handling coupon codes, aligning with the PR objectives.