feat: add getGasPrice rpc provider method #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivpavici
reviewed
Apr 3, 2024
ivpavici
requested changes
Apr 3, 2024
PhilippeR26
requested changes
Apr 3, 2024
src/provider/rpc.ts
Outdated
| @@ -100,6 +100,12 @@ export class RpcProvider implements ProviderInterface { | |||
| return this.channel.getBlockWithTxs(blockIdentifier); | |||
| } | |||
|
|
|||
| public async getGasPrice(blockIdentifier?: BlockIdentifier) { | |||
| return this.channel | |||
| .getBlockWithTxs(blockIdentifier) | |||
There was a problem hiding this comment.
getBlockWithTxHashes should generate less amount of data to receive, and will nevertheless return the L1 gas price
There was a problem hiding this comment.
I checked the response from BlastAPI but I couldn't find details of l1 gas price:
There was a problem hiding this comment.
On my side, with
const bl=await provider.getBlockWithTxHashes();https://starknet-sepolia.public.blastapi.io/rpc/v0_7
{
l1_da_mode: 'BLOB',
l1_data_gas_price: { price_in_fri: '0x91acb74c302d3', price_in_wei: '0x14f44f92900' },
l1_gas_price: { price_in_fri: '0x2d7f150f9892', price_in_wei: '0x68b5b1857' },
parent_hash: '0x16cc570bf6841d72a650ac06eefe965f8325c01d80df0ed5de2d3b03d62c6ec',
sequencer_address: '0x1176a1bd84444c89232ec27754698e5d2e7e1a7f1539f12027f28b23ec9f3d8',
starknet_version: '0.13.1',
status: 'PENDING',
timestamp: 1712319031,
transactions: [
https://starknet-sepolia.public.blastapi.io/rpc/v0_6
{
l1_gas_price: { price_in_fri: '0x2782d833b2c3', price_in_wei: '0x5b07580b4' },
parent_hash: '0x2ef3f69a56a90ca2864d4679aa64e857b72b7c9702fb3e3caaf07d863da79d1',
sequencer_address: '0x1176a1bd84444c89232ec27754698e5d2e7e1a7f1539f12027f28b23ec9f3d8',
starknet_version: '0.13.1',
status: 'PENDING',
timestamp: 1712319274,
transactions: [
Same with mainnet, same with Nethermind.
So, it should work.
There was a problem hiding this comment.
Your problem is probably related to a connection to rpc v0.4 or v0.5 (as it's not described in your url)
There was a problem hiding this comment.
Fixed ✅. What caused the problem earlier was because I was using older RPC version. @PhilippeR26
ivpavici
approved these changes
Apr 5, 2024
- change the helper method of `getL1GasPrice()` from `getBlockWithTxs()` to `getBlockWithTxHashes()`
PhilippeR26
approved these changes
Apr 5, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
# [6.8.0](v6.7.0...v6.8.0) (2024-04-23) ### Bug Fixes * starkne types 0.7 ([#1087](#1087)) ([b038c76](b038c76)) * tslib ([#1068](#1068)) ([dd7dc10](dd7dc10)) * **utils:** fix block identifier ([#1076](#1076)) ([0a3499d](0a3499d)) ### Features * add getGasPrice rpc provider method ([#1056](#1056)) ([d396275](d396275)) * Export function parseCalldataField() ([4d59658](4d59658)) * rpc 0.7.1 ([#1071](#1071)) ([11dc600](11dc600))
|
🎉 This PR is included in version 6.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ivpavici
added a commit
that referenced
this pull request
Apr 25, 2024
* chore(release): 6.8.0 [skip ci] # [6.8.0](v6.7.0...v6.8.0) (2024-04-23) ### Bug Fixes * starkne types 0.7 ([#1087](#1087)) ([b038c76](b038c76)) * tslib ([#1068](#1068)) ([dd7dc10](dd7dc10)) * **utils:** fix block identifier ([#1076](#1076)) ([0a3499d](0a3499d)) ### Features * add getGasPrice rpc provider method ([#1056](#1056)) ([d396275](d396275)) * Export function parseCalldataField() ([4d59658](4d59658)) * rpc 0.7.1 ([#1071](#1071)) ([11dc600](11dc600)) * docs: add paragrapher for encode decode tool * Update CHANGELOG.md --------- Co-authored-by: Toni Tabak <tabaktoni@gmail.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Ivan Pavičić <ivan.pavicic@live.com>
ivpavici
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(release): 6.8.0 [skip ci] # [6.8.0](v6.7.0...v6.8.0) (2024-04-23) ### Bug Fixes * starkne types 0.7 ([#1087](#1087)) ([b038c76](b038c76)) * tslib ([#1068](#1068)) ([dd7dc10](dd7dc10)) * **utils:** fix block identifier ([#1076](#1076)) ([0a3499d](0a3499d)) ### Features * add getGasPrice rpc provider method ([#1056](#1056)) ([d396275](d396275)) * Export function parseCalldataField() ([4d59658](4d59658)) * rpc 0.7.1 ([#1071](#1071)) ([11dc600](11dc600)) * chore/add JsDoc for address.ts file * update/ change address jsDoc - Add quotes to address string - Change address to get more zeros * feat/ Add JSDoc for encode.ts * update/ fix comments of encode.ts * update/ Fix last comment --------- Co-authored-by: Toni Tabak <tabaktoni@gmail.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Closes #761
RPC version (if applicable)
...
Usage related changes
...
Development related changes
...
Checklist: