Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lose ChainId in Provider #1081

Open
tabaktoni opened this issue Apr 15, 2024 · 1 comment
Open

Lose ChainId in Provider #1081

tabaktoni opened this issue Apr 15, 2024 · 1 comment
Labels
Type: feature New feature or request

Comments

@tabaktoni
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
get-starkness implement ChainId instead of StarknetChainId

/**
 * chain id, given in hex representation.
 * @pattern "^0x[a-fA-F0-9]+$"
 */
export type ChainId = string;

The definition is in starkness-types

Users can set any custom L2/L3 chain ID

Describe the solution you'd like
Accordingly to this as Dhruv suggested Starknetjs should also support adding custom chain ID
This should be enabled/refactored on Provider

Describe alternatives you've considered
There is no alternative (level restrained as it is)

Additional context
get-starknet
starknet-types

@tabaktoni tabaktoni added the Type: feature New feature or request label Apr 15, 2024
@princeibs
Copy link
Contributor

I would like to hop on this @tabaktoni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants